fix(nuxt): solve false warning when using useRoute
#26633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
approved these changes
Apr 3, 2024
danielroe
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolve #26612
📚 Description
When attempting the reproduction of linked issue, it results in a warning message advising users not to utilize
useRoutewithin middleware. This advice is misleading in this context.In this PR, I tryed to update the return value in
isProcessingMiddleware().Since the Nuxt 3.5.0, both asynchronous and synchronous middleware have been able to properly access the Nuxt instance. However, if
useNuxtApp()withinisProcessingMiddlewarethrows an error, it conclusively indicates that the execution is not happening within a plugin, Nuxt hook, Nuxt middleware, or Vue setup function.Thank you for reviewing this. If there's anything I might have overlooked, please don't hesitate to let me know.