Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 5, 2024

🔗 Linked issue

Continues #26583

📚 Description

  • Updated to the latest @nuxt/eslint-config, which contains plugins like jsdoc and unicorn.
  • Remove standard config, move to ESLint Stylistic for future proof
  • Cleanup eslint.config, make it more readable and extensible
  • Disable a few rules to align more with the original behavior and keep the changes minimal.

In the meantime, I guess it could be a good chance for us to review some rules and do the linting once?

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

socket-security bot commented Apr 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +2 93.6 kB types
npm/[email protected] Transitive: environment, filesystem +28 3.13 MB azat-io
npm/[email protected] Transitive: environment, eval, filesystem, network +8 1.69 MB antfu

🚮 Removed packages: npm/@eslint/[email protected], npm/@nuxt/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Apr 5, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Potential typo squat npm/[email protected]

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Comment on lines 82 to 88
...{
// TODO: Discuss if we want to enable this
'@typescript-eslint/ban-types': 'off',
// TODO: Discuss if we want to enable this
'@typescript-eslint/no-explicit-any': 'off',
// TODO: Discuss if we want to enable this
'@typescript-eslint/no-invalid-void-type': 'off'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the rules that creating quite a few warnings - we might want to enable them eventually but would requires some updates to the code.

@danielroe danielroe changed the title chore: cleanup eslint rules, use the latest @nuxt/eslint-config chore: cleanup eslint rules with latest @nuxt/eslint-config Apr 5, 2024
@danielroe danielroe merged commit f209158 into main Apr 5, 2024
@danielroe danielroe deleted the chore/eslint-config branch April 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants