fix(nuxt): call app:error in ssr#28139
Closed
huang-julien wants to merge 1 commit into
Closed
Conversation
|
|
Member
|
Could you share a reproduction of the issue? 🙏 We should be calling If this isn't being called (because it's not throwing an error in the render function) then we should probably call in the |
Member
Author
|
I think error handling are swallowed due to suspense .... |
Member
Author
|
closeing in favor of #28162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
This PR reverts partially #20585 .
Currently throwing an error in a vue component does call
app:errorbut not when callingshowError. The issue mentionned does not happen anymore (app:error being called twice)