Run & review this pull request in StackBlitz Codeflow.

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/kit@34739

npm i https://pkg.pr.new/@nuxt/nitro-server@34739

npm i https://pkg.pr.new/nuxt@34739

npm i https://pkg.pr.new/@nuxt/rspack-builder@34739

npm i https://pkg.pr.new/@nuxt/schema@34739

npm i https://pkg.pr.new/@nuxt/vite-builder@34739

npm i https://pkg.pr.new/@nuxt/webpack-builder@34739

commit: 8587314

Merging this PR will not alter performance

✅ 20 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing yamachi4416:not-add-import-resolve-condition-to-ssr (8587314) with main (8c078f4)²}

Walkthrough

The change modifies the SSR Vite environment configuration within the bundle function. Previously, the 'import' condition was unconditionally added to config.resolve.conditions. The code now sets config.resolve.conditions exclusively to the values from nitro.options.exportConditions, then explicitly filters out the 'import' condition with a TODO annotation for removal in v5.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@yamachi4416 I've reverted this for both 4.x and 3.x branches as it was causing issues with vue-router v5.

I'd happily re-open this, but let's do it against just 4.x to test properly 🙏

@danielroe
thank you so much 🙏
I will try to resolve and test it against the 4.x branch.