fix(google-maps): missing types for <ScriptGoogleMaps/>
#560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BobbieGoede is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The generated types for the
<ScriptGoogleMaps/>is empty, see thedist/runtime/components/GoogleMaps/ScriptGoogleMaps.d.vue.tsfile.You can see the following error while building this module:
Based on this error I exported the
PlaceholderOptionsin the component, which resolves the error and type generation.This behavior is not present in the playground setup, since it is directly importing source code instead of using a stub/build/package. There may be other functionality that work in the playground that differ in actual projects, this issue in particular is an outlier in that it logs an error during build.