Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(deps): prune package duplicates from lockfile #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2020
Merged

chore(deps): prune package duplicates from lockfile #627

merged 3 commits into from
Nov 15, 2020

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 14, 2020 •
edited
Loading

This PR should bring back the lovely ✔️

It does so by:

  • removing duplicates from lockfile

  • upgrading vue to 2.6.12

    Current test failure

      Vue packages version mismatch:

  - [email protected] (/home/circleci/project/node_modules/vue/dist/vue.runtime.common.js)
  - [email protected] (/home/circleci/project/node_modules/tib/node_modules/vue-template-compiler/package.json)

  This may cause things to work incorrectly. Make sure to use the same version for both.
  If you are using vue-loader@>=10.0, simply update vue-template-compiler.
  If you are using vue-loader@<10.0 or vueify, re-installing vue-loader/vueify should bump vue-template-compiler to the latest.

    at Object.<anonymous> (node_modules/tib/node_modules/vue-template-compiler/index.js:10:9)
    at Object.<anonymous> (node_modules/tib/lib/tib-browserstack-local.js:27:29)

  • upgrading chromedriver to v86

    Current test failure

      BrowserError: SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 83

I've deliberately not upgraded the other packages as I realise that's a separate set of decisions.

@codecov
Copy link

codecov bot commented Nov 14, 2020 •
edited
Loading

Codecov Report

Merging #627 (7fdced1) into master (e04ae64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          33       33           
  Lines         687      687           
  Branches      212      212           
=======================================
  Hits          678      678           
  Misses          5        5           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04ae64...7fdced1. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review November 14, 2020 18:34
@pimlie pimlie merged commit 74182e3 into nuxt:master Nov 15, 2020
@pimlie
Copy link
Collaborator

pimlie commented Nov 15, 2020

Thx!

@danielroe danielroe deleted the regenerate-lockfile branch November 15, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pimlie