Remove redundant copy of libmrc_pymrc.so#429
Merged
rapids-bot[bot] merged 7 commits intoJan 5, 2024
Merged
Conversation
…s from being owned by root
mdemoret-nv
approved these changes
Jan 4, 2024
mdemoret-nv
left a comment
Contributor
There was a problem hiding this comment.
Lets make sure the conda build works correctly on this before mergine.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-24.03 #429 +/- ##
=============================================
Coverage 74.00% 74.00%
=============================================
Files 394 394
Lines 13955 13955
Branches 1053 1053
=============================================
Hits 10327 10327
Misses 3628 3628
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
libmrc_pymrc.sofrom being installed into python's site-packages dir, as this lib is already present in the lib dir.root:root, simply ensuring the env retains thecondagroup permission wasn't sufficient ascmakeattempts to modify exiting dirs (https://gitlab.kitware.com/cmake/cmake/-/issues/10978), and runningchmod -Rafter the fact is too slow.Closes #428
Checklist