Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add IoScheduler to enable epoll-based Task scheduling#448

Merged
rapids-bot[bot] merged 9 commits into
nv-morpheus:branch-24.03from
cwharris:io-scheduler
Feb 29, 2024
Merged

Add IoScheduler to enable epoll-based Task scheduling#448
rapids-bot[bot] merged 9 commits into
nv-morpheus:branch-24.03from
cwharris:io-scheduler

Conversation

@cwharris

Copy link
Copy Markdown
Contributor

Description

Add the io_scheduler from libcoro, rename to IoScheduler, use standard code styles, and adjust implementation to support MRC's other libcoro port details.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Feb 28, 2024
@cwharris cwharris marked this pull request as ready for review February 28, 2024 20:20
@cwharris cwharris requested review from a team as code owners February 28, 2024 20:20

@mdemoret-nv mdemoret-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the PR name before merging

@cwharris cwharris changed the title IoScheduler Add IoScheduler to enable epoll-based Task scheduling Feb 28, 2024
@codecov

codecov Bot commented Feb 29, 2024

Copy link
Copy Markdown

Codecov Report

Merging #448 (b810ee3) into branch-24.03 (6c4256d) will decrease coverage by 0.26%.
The diff coverage is 58.22%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.03     #448      +/-   ##
================================================
- Coverage         74.03%   73.78%   -0.26%     
================================================
  Files               394      397       +3     
  Lines             13955    14184     +229     
  Branches           1053     1105      +52     
================================================
+ Hits              10331    10465     +134     
- Misses             3624     3719      +95     
Flag Coverage Δ
cpp 70.29% <58.22%> (-0.21%) ⬇️
py 41.72% <0.00%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/mrc/include/mrc/coroutines/detail/poll_info.hpp 100.00% <100.00%> (ø)
cpp/mrc/include/mrc/coroutines/scheduler.hpp 100.00% <ø> (ø)
cpp/mrc/src/public/coroutines/task_container.cpp 79.06% <ø> (ø)
...thon/mrc/_pymrc/include/pymrc/asyncio_runnable.hpp 95.23% <ø> (ø)
...hon/mrc/_pymrc/include/pymrc/asyncio_scheduler.hpp 70.00% <20.00%> (-18.24%) ⬇️
cpp/mrc/include/mrc/coroutines/io_scheduler.hpp 10.00% <10.00%> (ø)
cpp/mrc/src/public/coroutines/io_scheduler.cpp 65.19% <65.19%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4256d...b810ee3. Read the comment docs.

@cwharris

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 3010601 into nv-morpheus:branch-24.03 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants