Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding RoundRobinRouter node type for distributing values to downstream nodes#449

Merged
rapids-bot[bot] merged 2 commits into
nv-morpheus:branch-24.03from
mdemoret-nv:mdd_round-robin-router-typeless
Mar 7, 2024
Merged

Adding RoundRobinRouter node type for distributing values to downstream nodes#449
rapids-bot[bot] merged 2 commits into
nv-morpheus:branch-24.03from
mdemoret-nv:mdd_round-robin-router-typeless

Conversation

@mdemoret-nv

Copy link
Copy Markdown
Contributor

Description

  1. Adds a new C++ type RoundRobinRouterTypeless which is very similar to BroadcastTypeless except it only pushes values to one of the downstream connections instead of copying
  2. Adds a new Python type RoundRobinRouter which allows using the RoundRobinRouterTypeless from python
  3. Adds a C++ test to confirm connectivity
  4. Adds Python tests to verify output

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change feature request New feature or request labels Mar 6, 2024
@mdemoret-nv mdemoret-nv requested review from a team as code owners March 6, 2024 22:18
@codecov

codecov Bot commented Mar 6, 2024

Copy link
Copy Markdown

Codecov Report

Merging #449 (8f96338) into branch-24.03 (3010601) will increase coverage by 0.03%.
The diff coverage is 86.36%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.03     #449      +/-   ##
================================================
+ Coverage         73.74%   73.78%   +0.03%     
================================================
  Files               397      398       +1     
  Lines             14184    14228      +44     
  Branches           1104     1108       +4     
================================================
+ Hits              10460    10498      +38     
- Misses             3724     3730       +6     
Flag Coverage Δ
cpp 70.30% <82.50%> (+0.03%) ⬆️
py 41.89% <86.36%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/mrc/core/node.cpp 100.00% <100.00%> (ø)
...mrc/node/operators/round_robin_router_typeless.hpp 85.00% <85.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3010601...8f96338. Read the comment docs.

@mdemoret-nv

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 2dbd985 into nv-morpheus:branch-24.03 Mar 7, 2024
@mdemoret-nv mdemoret-nv deleted the mdd_round-robin-router-typeless branch March 7, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants