Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removing the INFO log when creating an AsyncioRunnable#456

Merged
rapids-bot[bot] merged 1 commit into
nv-morpheus:branch-24.03from
mdemoret-nv:mdd_removing-asyncio-log-message
Mar 15, 2024
Merged

Removing the INFO log when creating an AsyncioRunnable#456
rapids-bot[bot] merged 1 commit into
nv-morpheus:branch-24.03from
mdemoret-nv:mdd_removing-asyncio-log-message

Conversation

@mdemoret-nv

Copy link
Copy Markdown
Contributor

Description

When running an instance of the AsyncioRunnable class, it populates the output with:

I20240313 16:41:26.300143 3296734 asyncio_runnable.hpp:246] AsyncioRunnable::run() > Creating new event loop
I20240313 16:41:26.300436 3296734 asyncio_runnable.hpp:259] AsyncioRunnable::run() > Calling run_until_complete() on main_task()

This PR changes that to a DVLOG(10) since this information is more tracing than actually informative.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Mar 13, 2024
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner March 13, 2024 21:03
@codecov

codecov Bot commented Mar 14, 2024

Copy link
Copy Markdown

Codecov Report

Merging #456 (44ec3a2) into branch-24.03 (a920644) will increase coverage by 1.66%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.03     #456      +/-   ##
================================================
+ Coverage         72.15%   73.81%   +1.66%     
================================================
  Files               398      398              
  Lines             14266    14243      -23     
  Branches           1110     1110              
================================================
+ Hits              10294    10514     +220     
+ Misses             3972     3729     -243     
Flag Coverage Δ
cpp 70.35% <ø> (+1.74%) ⬆️
py 41.87% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...thon/mrc/_pymrc/include/pymrc/asyncio_runnable.hpp 95.08% <ø> (-0.16%) ⬇️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a920644...44ec3a2. Read the comment docs.

@dagardner-nv dagardner-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 9cf1ebc into nv-morpheus:branch-24.03 Mar 15, 2024
@mdemoret-nv mdemoret-nv deleted the mdd_removing-asyncio-log-message branch March 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants