Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Incorrect docstring in mrc.core.coro#503

Merged
rapids-bot[bot] merged 4 commits into
nv-morpheus:branch-24.10from
dagardner-nv:david-coro-492
Oct 16, 2024
Merged

Fix Incorrect docstring in mrc.core.coro#503
rapids-bot[bot] merged 4 commits into
nv-morpheus:branch-24.10from
dagardner-nv:david-coro-492

Conversation

@dagardner-nv

Copy link
Copy Markdown
Contributor

Description

  • Include MRC libs with quotes not <>
  • Add MRC version string to coro module (all the other Python modules have this)
  • Fix spelling mistake in a comment in python/mrc/core/executor.cpp

Closes #492

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner October 7, 2024 16:56
@dagardner-nv dagardner-nv added doc Improvements or additions to documentation non-breaking Non-breaking change labels Oct 7, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 7, 2024
@mdemoret-nv

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot Bot merged commit 4f23470 into nv-morpheus:branch-24.10 Oct 16, 2024
@codecov

codecov Bot commented Oct 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.97%. Comparing base (cef7f0b) to head (80f24bc).
Report is 2 commits behind head on branch-24.10.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-24.10     #503   +/-   ##
=============================================
  Coverage         73.97%   73.97%           
=============================================
  Files               403      403           
  Lines             14467    14475    +8     
  Branches           1136     1137    +1     
=============================================
+ Hits              10702    10708    +6     
- Misses             3765     3767    +2     
Flag Coverage Δ
cpp 69.28% <100.00%> (-1.24%) ⬇️
py 42.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/mrc/_pymrc/include/pymrc/coro.hpp 94.11% <ø> (ø)
python/mrc/core/coro.cpp 100.00% <100.00%> (ø)
python/mrc/core/executor.cpp 83.33% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef7f0b...80f24bc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Incorrect docstrings in mrc.core.coro

2 participants