Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CMake issue which installed headers incorrectly during conda build#511

Merged
rapids-bot[bot] merged 6 commits into
nv-morpheus:branch-24.10from
mdemoret-nv:mdd_fix-cmake-conda
Oct 24, 2024
Merged

Fix CMake issue which installed headers incorrectly during conda build#511
rapids-bot[bot] merged 6 commits into
nv-morpheus:branch-24.10from
mdemoret-nv:mdd_fix-cmake-conda

Conversation

@mdemoret-nv

Copy link
Copy Markdown
Contributor

Fixes a few issues:

  • Headers were being installed incorrectly with new HEADER_SET
  • Fixed packages for pymrc component
  • Standardized the component naming

Closes #509

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change conda-build Enables running the conda-build step on a PR labels Oct 24, 2024
@mdemoret-nv mdemoret-nv requested review from a team as code owners October 24, 2024 00:14
@mdemoret-nv mdemoret-nv changed the base branch from branch-25.02 to branch-24.10 October 24, 2024 00:18
@mdemoret-nv

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 7abfdf7 into nv-morpheus:branch-24.10 Oct 24, 2024
@mdemoret-nv mdemoret-nv deleted the mdd_fix-cmake-conda branch October 24, 2024 03:10
@codecov

codecov Bot commented Oct 24, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (a4b2ca1) to head (45579e1).
Report is 1 commits behind head on branch-24.10.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #511      +/-   ##
================================================
- Coverage         74.17%   74.15%   -0.03%     
================================================
  Files               407      407              
  Lines             15049    15049              
  Branches           1191     1191              
================================================
- Hits              11163    11159       -4     
- Misses             3886     3890       +4     
Flag Coverage Δ
cpp 70.69% <ø> (-0.03%) ⬇️
py 44.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b2ca1...45579e1. Read the comment docs.

rapids-bot Bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Oct 24, 2024
…RC (#1981)

Depends on PR nv-morpheus/MRC#511 being completed, merged, and a new conda package uploaded before testing can begin.

Fixes a small issue where MRC updated a function to be private to avoid incorrect usage of it.

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Christopher Harris (https://github.com/cwharris)

URL: #1981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working conda-build Enables running the conda-build step on a PR non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: CMake changes introduced in PR #502 causes CPM errors fetching UCX in Morpheus

3 participants