Fix bug where AsyncioRunnable hangs if process_one throws and the source is not emitting new values#523
Merged
rapids-bot[bot] merged 10 commits intoJan 13, 2025
Conversation
… been raised in process_one, but AsyncioRunnable is blocked on read_async in the situation where the source isn't emitting any values TODO: Remove debug logging TODO: Remove static_pointer_cast
AsyncioRunnable hangs if process_one throws and the source is not emitting new values
willkill07
requested changes
Jan 13, 2025
willkill07
left a comment
Member
There was a problem hiding this comment.
One nit on consistency of unimplemented behavior. Otherwise LGTM.
willkill07
approved these changes
Jan 13, 2025
Contributor
Author
|
/merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #523 +/- ##
=================================================
+ Coverage 54.34% 74.01% +19.66%
=================================================
Files 372 407 +35
Lines 12553 15104 +2551
Branches 1104 1199 +95
=================================================
+ Hits 6822 11179 +4357
+ Misses 5731 3925 -1806
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 168 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AsyncioRunnablewill now callon_state_update(state_t::Kill)when an exception is caughtawait_readwithawait_read_untilallowingAsyncioRunnableto checkstop_source.stop_requested()await_read_untilmethod inIEdgeReadable, unfortunately this interface has numerous subclasses which all then needed newawait_read_untilmethods, even thoughEdgeChannelReaderis the only class that really needed it. Alternatives:AsyncSinkperform a static cast ofthis->get_readable_edge()toEdgeChannelReaderawait_read_untilmethod inIEdgeReadablebut give it an implementation that throws a non-impl exception (or asserts false)Checklist