Bugfix: Fix IoScheduler::yield_until and improve tests#533
Merged
rapids-bot[bot] merged 1 commit intoJan 30, 2025
Conversation
dagardner-nv
approved these changes
Jan 30, 2025
Signed-off-by: Will Killian <[email protected]>
c2bc35b to
5ad7e3d
Compare
Member
Author
|
/merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #533 +/- ##
================================================
- Coverage 74.03% 74.00% -0.04%
================================================
Files 407 407
Lines 15103 15103
Branches 1198 1198
================================================
- Hits 11182 11177 -5
- Misses 3921 3926 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the implementation of
yield_forandyield_untilwhile also eliminating a bug inyield_forwhich can cause it to prematurely notify.Closes #532
Checklist