Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adopt Python 3.12#544

Merged
rapids-bot[bot] merged 34 commits into
nv-morpheus:branch-25.06from
willkill07:will-py-312-2181
Feb 25, 2025
Merged

Adopt Python 3.12#544
rapids-bot[bot] merged 34 commits into
nv-morpheus:branch-25.06from
willkill07:will-py-312-2181

Conversation

@willkill07

@willkill07 willkill07 commented Feb 24, 2025

Copy link
Copy Markdown
Member

Description

This is #541 but having all commits rebased on branch-25.06

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@willkill07 willkill07 requested review from a team as code owners February 24, 2025 19:12
willkill07 and others added 20 commits February 24, 2025 14:19
Signed-off-by: Will Killian <[email protected]>
@willkill07 willkill07 changed the title Adopt Python 3.12Will py 312 2181 Adopt Python 3.12 Feb 24, 2025
@willkill07 willkill07 added non-breaking Non-breaking change feature request New feature or request conda-build Enables running the conda-build step on a PR labels Feb 24, 2025
@dagardner-nv

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot Bot merged commit bae997f into nv-morpheus:branch-25.06 Feb 25, 2025
@codecov

codecov Bot commented Feb 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.74%. Comparing base (ac64c4f) to head (7eed185).
Report is 1 commits behind head on branch-25.06.

Files with missing lines Patch % Lines
python/mrc/_pymrc/src/executor.cpp 0.00% 5 Missing ⚠️
cpp/mrc/src/public/modules/plugins.cpp 0.00% 3 Missing ⚠️
python/mrc/_pymrc/src/operators.cpp 40.00% 3 Missing ⚠️
python/mrc/_pymrc/src/segment.cpp 0.00% 2 Missing ⚠️
python/mrc/_pymrc/src/subscriber.cpp 0.00% 2 Missing ⚠️
cpp/mrc/src/internal/system/device_info.cpp 0.00% 1 Missing ⚠️
cpp/mrc/src/public/edge/edge_builder.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-25.06     #544      +/-   ##
================================================
- Coverage         74.01%   73.74%   -0.28%     
================================================
  Files               407      407              
  Lines             15103    15122      +19     
  Branches           1198     1201       +3     
================================================
- Hits              11178    11151      -27     
- Misses             3925     3971      +46     
Flag Coverage Δ
cpp 70.67% <27.58%> (+0.01%) ⬆️
py 43.59% <17.24%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/mrc/_pymrc/include/pymrc/coro.hpp 91.17% <100.00%> (-2.95%) ⬇️
python/mrc/_pymrc/src/module_wrappers/pickle.cpp 100.00% <100.00%> (ø)
...n/mrc/_pymrc/src/module_wrappers/shared_memory.cpp 84.31% <100.00%> (+0.98%) ⬆️
python/mrc/_pymrc/src/utilities/deserializers.cpp 78.57% <100.00%> (ø)
cpp/mrc/src/internal/system/device_info.cpp 56.09% <0.00%> (ø)
cpp/mrc/src/public/edge/edge_builder.cpp 55.93% <66.66%> (ø)
python/mrc/_pymrc/src/segment.cpp 77.72% <0.00%> (-3.11%) ⬇️
python/mrc/_pymrc/src/subscriber.cpp 27.27% <0.00%> (ø)
cpp/mrc/src/public/modules/plugins.cpp 54.26% <0.00%> (ø)
python/mrc/_pymrc/src/operators.cpp 79.67% <40.00%> (-1.78%) ⬇️
... and 1 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64c4f...7eed185. Read the comment docs.

KyleFromNVIDIA pushed a commit to KyleFromNVIDIA/MRC that referenced this pull request Apr 23, 2025
This is nv-morpheus#541 but having all commits rebased on `branch-25.06`

* `pybind11::error_already_set` now inherits from `std::exception` rather than `std::runtime_error`
* Adopt Pybind11 2.12, required for Python 3.12 support
* Disable Pybind's ing_ref/dec_ref checking (nv-morpheus#542)
* Adopt updated version of versioneer, removing the need for `versioneer.py` in the repo.
* Work-around for llvm/llvm-project#92948 ref: nv-morpheus#543
* Fetch commit history so proper version can be detected for tests

Authors:
  - Will Killian (https://github.com/willkill07)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: nv-morpheus#544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda-build Enables running the conda-build step on a PR feature request New feature or request non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants