Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to Rapids 25.06#558

Merged
rapids-bot[bot] merged 12 commits into
nv-morpheus:branch-25.10from
dagardner-nv:david-rapids-25.06
Jan 13, 2026
Merged

Update to Rapids 25.06#558
rapids-bot[bot] merged 12 commits into
nv-morpheus:branch-25.10from
dagardner-nv:david-rapids-25.06

Conversation

@dagardner-nv

@dagardner-nv dagardner-nv commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Remove the align_up/align_down methods these were thin wrappers around RMM's methods of the same name. These methods were not used outside of the arena code, and due to changes on the RMM side they were creating build errors.
  • Adopt cmake 3.30 (required by rapids-cmake)
  • Resolve version conflicts in the conda build

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv
Bump rapids version
c61e8aa 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Skip failing test
03b4b52 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Update to cmake 3.30
3b0555f 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Update cmake rapids
c11b482 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
rmm::align_up / rmm::align_down are no longer constexpr functions
8fb38f8 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Remove our own align_up/align_down methods, these were not used outsi…
49c993d 
…de of the arena code, and were causing build errors

Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv self-assigned this Jan 13, 2026
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality breaking Breaking change labels Jan 13, 2026
@Salonijain27

Salonijain27 commented Jan 13, 2026

Copy link
Copy Markdown

Approved from a dependency point of view

@dagardner-nv dagardner-nv marked this pull request as ready for review January 13, 2026 21:22
@dagardner-nv dagardner-nv requested review from a team as code owners January 13, 2026 21:22
@dagardner-nv
Update CR
65ec0e3 
Signed-off-by: David Gardner <[email protected]>
@github-project-automation github-project-automation Bot moved this to Review - Approved in Morpheus Boards Jan 13, 2026
@dagardner-nv
IWYU fix
b8abc5f 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Update CR year
715e315 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv added the conda-build Enables running the conda-build step on a PR label Jan 13, 2026
@dagardner-nv

dagardner-nv commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 9a04ad3 into nv-morpheus:branch-25.10 Jan 13, 2026
39 checks passed
@github-project-automation github-project-automation Bot moved this from Review - Approved to Done in Morpheus Boards Jan 13, 2026
@codecov

codecov Bot commented Jan 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.10%. Comparing base (7f3d3af) to head (715e315).
⚠️ Report is 1 commits behind head on branch-25.10.

Files with missing lines Patch % Lines
.../mrc/include/mrc/memory/resources/detail/arena.hpp 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-25.10     #558      +/-   ##
================================================
- Coverage         72.11%   72.10%   -0.01%     
================================================
  Files               407      407              
  Lines             15143    15139       -4     
  Branches           1204     1204              
================================================
- Hits              10920    10916       -4     
  Misses             4223     4223
Flag Coverage Δ
cpp 68.58% <50.00%> (-0.01%) ⬇️
py 43.55% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/include/mrc/memory/resources/arena_resource.hpp 68.29% <100.00%> (ø)
.../mrc/include/mrc/memory/resources/detail/arena.hpp 71.72% <25.00%> (-0.76%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3d3af...715e315. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dagardner-nv dagardner-nv deleted the david-rapids-25.06 branch January 13, 2026 23:07
dagardner-nv added a commit to dagardner-nv/MRC that referenced this pull request Jan 21, 2026
@dagardner-nv
Revert "Update to Rapids 25.06 (nv-morpheus#558)"
89d888a 
This reverts commit 9a04ad3.

Signed-off-by: David Gardner <[email protected]>
dagardner-nv added a commit to dagardner-nv/MRC that referenced this pull request Jan 21, 2026
@dagardner-nv
Revert PR nv-morpheus#558 and update utilities
1d5ca42 
Signed-off-by: David Gardner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

breaking Breaking change conda-build Enables running the conda-build step on a PR improvement Improvement to existing functionality

Projects

Morpheus Boards
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dagardner-nv @Salonijain27 @willkill07