Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing parameter to lu1rec calls #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing parameter to lu1rec calls #11

wants to merge 1 commit into from

Conversation

jamesjer
Copy link

Building with LTO (link-time optimization) triggers compiler warnings that some callers of lu1rec pass arguments that don't match the declared parameters. Each such caller is missing the ilast parameter. This patch adds the missing arguments.

A typical warning looks like this (building with gfortran on an x86_64 Fedora 37 machine):

src/lusol8b.f:643:72: warning: type of 'lu1rec' does not match original declaration [-Wlto-type-mismatch]
  643 |       call lu1rec( m, .true., luparm, lrow, lena, a, indr, lenr, locr )
      |                                                                        ^
src/lusol_util.f:3715:23: note: type mismatch in parameter 10
 3715 |       subroutine lu1rec( n, reals, luparm, ltop, ilast,
      |                       ^
src/lusol_util.f:3715:23: note: 'lu1rec' was previously declared here
src/lusol_util.f:3715:23: note: code may be misoptimized unless '-fno-strict-aliasing' is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesjer