Default OSFallback to false for JS builds #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 92.72% 92.67% -0.05%
==========================================
Files 141 141
Lines 6406 6406
==========================================
- Hits 5940 5937 -3
- Misses 406 410 +4
+ Partials 60 59 -1
Continue to review full report at Codecov.
|
Contributor
|
Do we think we need to have a story for running js builds in ci? |
Implausiblyfun
approved these changes
Jan 18, 2022
Contributor
Implausiblyfun
left a comment
There was a problem hiding this comment.
Per conversation we will open an issue for js in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For JS targets, a call to the standard library's
ospackage to open a file will always error. This change alters thefileutilpackage, where all of oak's os file calls happen (outside of driver specific operations), to default to not make OS calls if the embedded file system fails a file lookup.