Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Cidaas provider #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 12, 2025
Merged

Add Cidaas provider #2273

merged 27 commits into from
Aug 12, 2025

Conversation

Bibob7
Copy link
Contributor

@Bibob7 Bibob7 commented Oct 18, 2023 •
edited
Loading

This Pull Request add a new provider type for the Cidaas IDP.

Description

Just add a new Provider type

Motivation and Context

Cidaas offers the usual OIDC flow, but the way how groups and roles are provided is special. Because of this, I added a formatting function to translate it into a valid format for the SessionState.

How Has This Been Tested?

I added tests for the new provider type and also use it already in our system.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@Bibob7 Bibob7 requested a review from a team as a code owner October 18, 2023 08:11
@Bibob7 Bibob7 changed the title Add cidaas provider Add Cidaas provider Oct 18, 2023
kvanzuijlen
kvanzuijlen previously requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@kvanzuijlen kvanzuijlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some docs please?

Also, is there a specific reason why the OIDC provider wouldn't suffice for this provider; what does this add that wasn't already possible with the OIDC provider?

@kvanzuijlen kvanzuijlen added this to the v8.0.0 milestone Oct 23, 2023
@JoelSpeed
Copy link
Member

Cidaas offers the usual OIDC flow, but the way how groups and roles are provided is special. Because of this, I added a formatting function to translate it into a valid format for the SessionState.

Can you expand on how the groups work for me please? I'm wondering if there's a way to handle this more generically for each provider that has a different group format, rather than overloading what we already have

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Jan 18, 2024
@github-actions github-actions bot closed this Jan 26, 2024
@tuunit tuunit reopened this Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label May 27, 2024
@github-actions github-actions bot closed this Jun 5, 2024
@tuunit tuunit reopened this Jun 23, 2024
@tuunit tuunit removed the Stale label Jun 23, 2024
@Teko012
Copy link
Contributor

Teko012 commented Aug 20, 2024

Hi @kvanzuijlen @JoelSpeed @tuunit! I was looking into getting back to this PR, so it can be merged. If you got clarification on these questions, and a rebase, are you open to get this merged still? I just wanna make sure we are not wasting time :) Thank you in advance!

tuunit
tuunit requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that his PR was sitting on the sidelines for so long. Overall the code quality looks good. Please fix the sorting and merge / rebase conflicts and then we will rerun the CI

@tuunit
Copy link
Member

tuunit commented Aug 20, 2024

@Teko012 thanks for reminding me of this PR

@Teko012 Teko012 force-pushed the add-cidaas-provider branch from d4b8195 to d660000 Compare August 21, 2024 16:01
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Oct 21, 2024
@Teko012
Copy link
Contributor

Teko012 commented Oct 21, 2024

This is still a work in progress.

@github-actions github-actions bot removed the Stale label Oct 22, 2024
@tuunit tuunit removed this from the v8.0.0 milestone Jan 4, 2025
@tuunit tuunit force-pushed the add-cidaas-provider branch from d660000 to 25355ce Compare January 12, 2025 12:26
@tuunit
Copy link
Member

tuunit commented Jan 12, 2025 •
edited
Loading

@Teko012 @Bibob7 sorry for the long wait. I force updated your PR and resolved the conflicts.

Is this ready for a final review and merge?

@tuunit tuunit force-pushed the add-cidaas-provider branch from 5997ced to 61d8278 Compare July 16, 2025 19:16
@tuunit
Copy link
Member

tuunit commented Jul 16, 2025

@Bibob7 I want to get this merged finally... Last but not least can you add a documentation page for the provider?

@github-actions github-actions bot removed the Stale label Jul 17, 2025
@Bibob7
Copy link
Contributor Author

Bibob7 commented Jul 21, 2025

@tuunit @kvanzuijlen: I added the requested doc page. Please go ahead.

@Bibob7 Bibob7 requested review from tuunit and kvanzuijlen July 29, 2025 07:13
tuunit
tuunit previously approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teko012
Copy link
Contributor

Teko012 commented Aug 4, 2025

Thanks. @tuunit can you merge it?

@tuunit tuunit merged commit 4c86a4d into oauth2-proxy:master Aug 12, 2025
6 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuunit tuunit tuunit approved these changes

@kvanzuijlen kvanzuijlen Awaiting requested review from kvanzuijlen

+1 more reviewer

@Teko012 Teko012 Teko012 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs go provider tests
Projects
OAuth2-Proxy Release Planning & Roadmap
Status: Proposed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bibob7 @JoelSpeed @Teko012 @tuunit @kvanzuijlen @architeckev