Thanks to visit codestin.com
Credit goes to github.com

Skip to content

structured config #2: legacy file structure refactoring and cookie support #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

structured config #2: legacy file structure refactoring and cookie support #2629

wants to merge 13 commits into from

Conversation

tuunit
Copy link
Member

@tuunit tuunit commented May 4, 2024 •
edited
Loading

Description

Warning

This is a PR stacked on top of introduce mapstructure decoder for yaml parsing #2628

Actual stacked changes can be viewed here:
https://github.com/tuunit/oauth2-proxy/pull/6/files

  1. Restructured the legacy_options.go by splitting it apart into one legacy_*.go file per type.
  2. Adding support for cookie options in alpha config
  3. Fixed bugs with the server config conversion and loading (missing json tags)
  4. Fixed bug with unmarshaling duration types

Motivation and Context

  1. Better readability and maintainability
  2. Easier to debug and remove later on

How Has This Been Tested?

  1. Test cases have been extend / adapted.
  2. Starting the application with toml config file
  3. Using the conversion function from toml to yaml
  4. Starting the application with yaml config file

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@tuunit tuunit force-pushed the legacy-file-structure-refactoring-and-cookie-support branch from 73a110d to a05b222 Compare May 4, 2024 16:20
@tuunit tuunit changed the title Legacy file structure refactoring and cookie support structured logging #2: legacy file structure refactoring and cookie support May 4, 2024
@tuunit tuunit mentioned this pull request May 4, 2024
Open
4 tasks
@tuunit tuunit changed the title structured logging #2: legacy file structure refactoring and cookie support structured config #2: legacy file structure refactoring and cookie support May 4, 2024
@tuunit tuunit mentioned this pull request May 5, 2024
Open
4 tasks
@tuunit tuunit force-pushed the legacy-file-structure-refactoring-and-cookie-support branch from a05b222 to 50f22a5 Compare May 5, 2024 17:22
@tuunit tuunit mentioned this pull request May 5, 2024
Open
4 tasks
@tuunit tuunit force-pushed the legacy-file-structure-refactoring-and-cookie-support branch from 8cc53d4 to 87c4389 Compare May 10, 2024 06:41
@tuunit tuunit marked this pull request as ready for review May 10, 2024 07:34
@tuunit tuunit requested a review from a team as a code owner May 10, 2024 07:34
@tuunit tuunit force-pushed the legacy-file-structure-refactoring-and-cookie-support branch from 87c4389 to f8037e1 Compare May 12, 2024 20:00
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@github-actions github-actions bot closed this Jul 20, 2024
@tuunit tuunit reopened this Sep 15, 2024
@tuunit tuunit removed the Stale label Sep 15, 2024
@tuunit tuunit mentioned this pull request Oct 1, 2024
Closed
4 tasks
@tuunit tuunit added this to the v8.0.0 milestone Jan 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

This pull request has been inactive for 180 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 14 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Jul 4, 2025
@github-actions github-actions bot closed this Jul 19, 2025
@tuunit tuunit reopened this Jul 20, 2025
@github-actions github-actions bot removed the Stale label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs go tests
Projects
OAuth2-Proxy Release Planning & Roadmap
Status: In Progress
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@tuunit