Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: reloadable server TLS certificate #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: reloadable server TLS certificate #2953

wants to merge 6 commits into from

Conversation

emsixteeen
Copy link
Contributor

@emsixteeen emsixteeen commented Feb 9, 2025 •
edited
Loading

Description

Allows Server TLS certificates to be reloaded via SIGHUP.

Motivation and Context

Addresses #2482

How Has This Been Tested?

Standard HTTP Suite Test. No Additional tests added.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@emsixteeen emsixteeen requested a review from a team as a code owner February 9, 2025 17:26
@github-actions github-actions bot added the go label Feb 9, 2025
@emsixteeen emsixteeen mentioned this pull request Feb 9, 2025
Closed
tuunit
tuunit requested changes Apr 13, 2025
View reviewed changes
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks. Furthermore, I would like to see some additional test coverage and a CHANGELOG.md entry :)

@tuunit tuunit changed the title Reloadable server TLS certificate feat: reloadable server TLS certificate Apr 13, 2025
@github-actions github-actions bot added the docs label Aug 19, 2025
@tuunit
Copy link
Member

tuunit commented Aug 19, 2025

Test coverage and additional documentation is still missing for this

@github-actions github-actions bot added the tests label Aug 19, 2025
@emsixteeen
Copy link
Contributor Author

Added some brief documentation. The additional test provides broader test coverage.

@emsixteeen
Copy link
Contributor Author

The CI check is failing because of a race condition. Not sure if this is related to the test suite itself, or if might have a broader impact beyond the tests.

I have another branch that uses sync/atomic instead (as opposed to a mutex) which seems to resolve the issue.

I'm happy to make that change here. If anyone has a moment, I’d really appreciate any feedback or a second look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuunit tuunit tuunit requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
docs go tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emsixteeen @tuunit