Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

MagicRB
Copy link
Contributor

@MagicRB MagicRB commented Aug 4, 2025

Fixes #3048

Description

Gitea doesn't properly fill in all the fields like GitHub, so implement a series of fallbacks.

Motivation and Context

When using oauth2-proxy with the GitHub provider backed by Gitea, team/org membership is broken.

How Has This Been Tested?

We've been running a slightly older version of this in production for 4 months. (one line change)

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

Not sure if this warrants tests or a changelog entry, if it does ill add those :) .

@MagicRB MagicRB requested a review from a team as a code owner August 4, 2025 12:54
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some documentation to the fields to explain why the fields Login and Name exist

Add a changelog entry for your PR

@tuunit tuunit changed the title bugfix: Gitaa team membership fix: Gitea team membership Aug 18, 2025
Gitea doesn't properly fill in all the fields like GitHub,
so implement a series of fallbacks.

Signed-off-by: magic_rb <[email protected]>
@tuunit tuunit force-pushed the fix-gitea-team-membership branch from 9d25434 to 5d08ca8 Compare August 19, 2025 06:29
@github-actions github-actions bot added the docs label Aug 19, 2025
@tuunit tuunit force-pushed the fix-gitea-team-membership branch from 5d08ca8 to de0ad8e Compare August 19, 2025 06:35
tuunit
tuunit previously approved these changes Aug 19, 2025
@tuunit tuunit force-pushed the fix-gitea-team-membership branch from de0ad8e to 0ccabf4 Compare August 19, 2025 06:36
@tuunit tuunit merged commit 8c1b2b6 into oauth2-proxy:master Aug 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to authenticate against organization membership with the Gitea (GitHub) provider
2 participants