Modernize ES6 #140
Open
Modernize ES6 #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerre
commented
Jul 14, 2021
- Convert to ES6 style class
- Removed bluebird in favor of native Node.js Promise
- document functions
- Fixed test so they exit properly
|
@mjsalinger if you'd like to add me as a contributor to this project I'd be happy to go through all the pull requests and issue and resolve them. I know this project has some security implications so if you'd rather not I understand. That said, it would be great for this project to move forward as you make updates to oauth2-server |
|
I really like your upgrade, gonna fork myself a copy out of your fork, because I would also bump oauth2-server to 3.1.1 at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.