Thanks to visit codestin.com
Credit goes to github.com

Skip to content

expires_in must be an integer, not a string in IMPLICIT #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JonathanHuot opened this issue Aug 6, 2018 · 0 comments
Closed

expires_in must be an integer, not a string in IMPLICIT #569

JonathanHuot opened this issue Aug 6, 2018 · 0 comments
Assignees
@JonathanHuot
Labels
OAuth2-Client This impact the client part of OAuth2.
Milestone
3.0.0

Comments

@JonathanHuot
Copy link
Member

RFC 6749 mandate expires_in to be an integer (https://tools.ietf.org/html/rfc6749#appendix-A.14) but looks like the integer conversion is not done for implicit grant (oauth2-client side).

We can see the current implementation for the oauth2.parameters.parse_token_response: https://github.com/oauthlib/oauthlib/blob/master/oauthlib/oauth2/rfc6749/parameters.py#L367

And the missing conversion code in the parse_implicit_response : https://github.com/oauthlib/oauthlib/blob/master/oauthlib/oauth2/rfc6749/parameters.py#L367
@JonathanHuot JonathanHuot added the OAuth2-Client This impact the client part of OAuth2. label Aug 6, 2018
@JonathanHuot JonathanHuot self-assigned this Aug 6, 2018
@JonathanHuot JonathanHuot added this to the 3.0.0 milestone Aug 6, 2018
@JonathanHuot JonathanHuot mentioned this issue Aug 6, 2018
Merged
JonathanHuot added a commit that referenced this issue Aug 12, 2018
@JonathanHuot
Merge pull request #570 from oauthlib/569_expires_in_implicit
05b1185 
#569: Implicit was not converting expires_in into integers
@JonathanHuot JonathanHuot mentioned this issue Dec 3, 2018
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonathanHuot JonathanHuot

Labels
OAuth2-Client This impact the client part of OAuth2.
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@JonathanHuot