Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed "make" command to test upstream with local oauthlib. #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2018
Merged

Fixed "make" command to test upstream with local oauthlib. #522

merged 2 commits into from
Mar 18, 2018

Conversation

JonathanHuot
Copy link
Member

Doing make command to test upstream compatibility is great, however it has different flaws I fixed:

  1. remove oauthlib references in upstream's project and replace it with local "dev" oauthlib: every dev should be able to run make to test their local changes before push.
  2. clean rule: cleaning the working directories should not be done automatically, else it becomes a pain to debug them
  3. python versions list should be based on the upstream's compatibility, and not on the oauthlib's compatibility (e.g. running plain tox everytime we can).
  4. added bottle-oauthlib

TBC: wait for requests/requests-oauthlib#306 to be integrated to master & we will able to replace Travis build command from tox to make. However, if one of their builds failed for a different reason than us, it breaks our CI job.

@coveralls
Copy link

coveralls commented Mar 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1175

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.4%) to 95.463%
Files with Coverage Reduction New Missed Lines %
oauthlib/oauth1/rfc5849/signature.py 2 99.28%
oauthlib/oauth1/rfc5849/endpoints/authorization.py 2 97.37%
oauthlib/oauth2/rfc6749/parameters.py 2 94.44%
oauthlib/oauth1/rfc5849/utils.py 2 100.0%
oauthlib/oauth2/rfc6749/tokens.py 2 93.53%
oauthlib/oauth1/rfc5849/parameters.py 2 100.0%
oauthlib/oauth1/rfc5849/init.py 3 92.13%
oauthlib/oauth2/rfc6749/utils.py 4 100.0%
oauthlib/common.py 9 98.53%
Totals Coverage Status
Change from base Build 1165: -0.4%
Covered Lines: 2630
Relevant Lines: 2755
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1174

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 95.463%
Totals Coverage Status
Change from base Build 1165: -0.4%
Covered Lines: 2630
Relevant Lines: 2755
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1174

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 95.463%
Totals Coverage Status
Change from base Build 1165: -0.4%
Covered Lines: 2630
Relevant Lines: 2755
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1174

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 95.463%
Totals Coverage Status
Change from base Build 1165: -0.4%
Covered Lines: 2630
Relevant Lines: 2755
💛 - Coveralls

@JonathanHuot
Copy link
Member Author

FYI,
With this Makefile, we have

@JonathanHuot JonathanHuot mentioned this pull request Mar 16, 2018
Merged
skion
skion approved these changes Mar 17, 2018
View reviewed changes
Copy link
Member

@skion skion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great for everything except for the django docs build, see my inline comment.

This will come in very handy for the 2.1/3.0 releases. 💯

Makefile
cd django-oauth-toolkit && tox -e "$(PYS)"
rm -rf django-oauth-toolkit
cd django-oauth-toolkit 2>/dev/null || git clone https://github.com/evonove/django-oauth-toolkit.git
cd django-oauth-toolkit && sed -i.old 's,deps =,deps= --editable=file://{toxinidir}/../,' tox.ini && tox -e py27,py35,py36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one appears to need an extra newline for the docs build...

@skion skion added this to the 2.0.7 milestone Mar 17, 2018
@skion skion merged commit ad61175 into oauthlib:master Mar 18, 2018
skion pushed a commit to skion/oauthlib that referenced this pull request Mar 18, 2018
@JonathanHuot @skion
Fixed "make" command to test upstream with local oauthlib. (oauthlib#522
7351153 
)

(cherry picked from commit ad61175)
@JonathanHuot JonathanHuot deleted the downstream-tests-fix branch March 19, 2018 11:27
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skion skion skion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanHuot @coveralls @skion