Avoid populating spurious token credentials #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiliamsouza
reviewed
May 7, 2018
| """Add attributes from an auth code response to self.""" | ||
|
|
||
| if 'code' in response: | ||
| self.code = response.get('code') |
There was a problem hiding this comment.
Initialize self.code in __init__?
wiliamsouza
reviewed
May 7, 2018
| @@ -168,5 +168,5 @@ def parse_request_uri_response(self, uri, state=None, scope=None): | |||
| .. _`Section 3.3`: https://tools.ietf.org/html/rfc6749#section-3.3 | |||
| """ | |||
| self.token = parse_implicit_response(uri, state=state, scope=scope) | |||
| self._populate_attributes(self.token) | |||
| self._populate_token_attributes(self.token) | |||
There was a problem hiding this comment.
Is there a test_populate_attributes for mobile application?
wiliamsouza
approved these changes
May 8, 2018
Closed
skion
added a commit
to skion/oauthlib
that referenced
this pull request
May 18, 2018
(cherry picked from commit 657065d)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures we do not pick up client attributes too early.