OIDC: Raise error=invalid_request when nonce is mandatory #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, only OIDC implicit was raising an error, but OIDC hybrid contain a couple of mandatory nonce, too.
|
@JonathanHuot Great work! Can you please link the specification that state that. |
|
Hi @wiliamsouza, it has been clarified recently. It was not explained like this when you started the implementation :-) Have a look at https://bitbucket.org/openid/connect/commits/31240ed1f177b16b589b54c3795ea0187fa5b85e and https://openid.bitbucket.io/connect/openid-connect-core-1_0.html#HybridAuthRequest |
2 tasks
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, only OIDC implicit was raising an error, but OIDC hybrid contain a couple of mandatory
nonce, too.As OIDC specification states,
nonceis REQUIRED or OPTIONAL depending theresponse_typeparameter.Mapping below:
response_type=code->nonceoptionalresponse_type=id_token token->noncerequiredresponse_type=id_token->noncerequiredresponse_type=code id_token->noncerequiredresponse_type=code id_token token->noncerequiredresponse_type=code token->nonceoptionalNote: I moved a couple of "Hybrid" tests which were in the
test_implicitfile instead oftest_hybrid. I have done that in a single commit, to ease the review.