Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix 670. AuthCode API must return the new PKCE attribute #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2019
Merged

Fix 670. AuthCode API must return the new PKCE attribute #671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71be50a
Fix 670. AuthCode API must return the new PKCE attribute
JonathanHuot Apr 26, 2019
5899512
Merge branch 'master' into 670-pkce-requestinfo
JonathanHuot May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix 670. AuthCode API must return the new PKCE attribute
  • Loading branch information
@JonathanHuot
JonathanHuot committed Apr 26, 2019
commit 71be50afdeaf99a0ba6ce5048851dcdd5620d880
3 changes: 3 additions & 0 deletions oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,12 +405,15 @@ def validate_authorization_request(self, request):
raise errors.MissingCodeChallengeError(request=request)

if request.code_challenge is not None:
request_info["code_challenge"] = request.code_challenge

# OPTIONAL, defaults to "plain" if not present in the request.
if request.code_challenge_method is None:
request.code_challenge_method = "plain"

if request.code_challenge_method not in self._code_challenge_methods:
raise errors.UnsupportedCodeChallengeMethodError(request=request)
request_info["code_challenge_method"] = request.code_challenge_method

# OPTIONAL. The scope of the access request as described by Section 3.3
# https://tools.ietf.org/html/rfc6749#section-3.3
Expand Down
6 changes: 4 additions & 2 deletions tests/oauth2/rfc6749/grant_types/test_authorization_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,10 @@ def test_pkce_default_method(self):
self.mock_validator.is_pkce_required.return_value = required
self.request.code_challenge = "present"
_, ri = self.auth.validate_authorization_request(self.request)
self.assertIsNotNone(ri["request"].code_challenge_method)
self.assertEqual(ri["request"].code_challenge_method, "plain")
self.assertIn("code_challenge", ri)
self.assertIn("code_challenge_method", ri)
self.assertEqual(ri["code_challenge"], "present")
self.assertEqual(ri["code_challenge_method"], "plain")

def test_pkce_wrong_method(self):
for required in [True, False]:
Expand Down