Use better regex for IPv6 to allow a lot more valid IPv6 addresses #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Apr 2, 2021
|
Hi! Hope this is what you had in mind - there were no unit tests at all for uri_validate or is_absolute_uri() so I tested for some cases, among which the ones that failed before the a046668 |
auvipy
reviewed
Apr 6, 2021
auvipy
approved these changes
Apr 6, 2021
|
Hi; it looks like this PR is stuck on review, @auvipy @JonathanHuot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current IPv6address regular expression leaves out a lot of IPv6 addresses, among which the loopback address
::1which is important for Loopback Interface Redirection (as described in RFC8252, https://tools.ietf.org/html/rfc8252#section-7.3). Also shorter addresses like fd01::1 or anything between this and a full length address seemed to be left out.This is a much shorter regular expression, and a suggestion for one that does match a lot of valid IPv6 addresses (if done by regular expressions - an alternative would be the use of socket or maybe IPAddr).