Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bug(#4504): add tests for compact array with method#4821

Merged
yegor256 merged 2 commits into
objectionary:masterfrom
maxonfjvipon:bug/#4504/fqn-error-with-compact-tuple
Jan 23, 2026
Merged

bug(#4504): add tests for compact array with method#4821
yegor256 merged 2 commits into
objectionary:masterfrom
maxonfjvipon:bug/#4504/fqn-error-with-compact-tuple

Conversation

@maxonfjvipon
Copy link
Copy Markdown
Member

@maxonfjvipon maxonfjvipon commented Jan 23, 2026

Closes: #4504

Summary by CodeRabbit

  • Tests
    • Added test cases covering "compact tuple with method" scenarios in parser and transpiler modules to validate syntax handling, ensure error-free parsing, and verify expected transpilation output (including stdout behavior).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

Two new YAML test resources were added to verify parsing and transpilation of compact tuples with method calls; no source code or public API changes.

Changes

Cohort / File(s) Summary
Test resources: compact-tuple-with-method
eo-maven-plugin/src/test/resources/org/eolang/maven/transpile-packs/compact-tuple-with-method.yaml, eo-parser/src/test/resources/org/eolang/parser/eo-syntax/compact-tuple-with-method.yaml
Added YAML test files defining input EO snippets, XSLT/sheets (one file empty), and assertions to validate correct parsing/transpilation and that no FQN or stdout invocation errors occur.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • yegor256

Poem

🐰 A tuple tucked neat and spry,
With methods hopping by and by,
Tests planted in a row,
To catch each tiny woe,
Hooray — the build can sigh and smile 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'compact array' but the changes are for 'compact tuple' test cases; the referenced issue is about an FQN error, not a feature about arrays. Correct the title to accurately reflect the changes: 'add tests for compact tuple with method' and ensure it aligns with issue #4504 about FQN error handling.
Linked Issues check ❓ Inconclusive The PR adds test cases that reproduce the failure scenario from issue #4504 but does not implement the actual fixes for the underlying FQN error or improve error messaging. Clarify whether the PR is intended only for test coverage or if it should also include fixes for detecting the problem earlier and improving error messages as described in #4504.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check ✅ Passed Both test files added are directly related to the compact tuple issue and reproduce the scenario from #4504, with no extraneous changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 23, 2026

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 202.683 186.083 -16.601 -8.19% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 16.601 ms/op (8.19%)

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@eo-parser/src/test/resources/org/eolang/parser/eo-syntax/compact-tuple-with-method.yaml`:
- Line 1: The YAML file compact-tuple-with-method.yaml has a leading blank line
causing yamllint to fail; remove the initial empty line at the top of
eo-parser/src/test/resources/org/eolang/parser/eo-syntax/compact-tuple-with-method.yaml
so the file starts immediately with the first YAML document line (no preceding
whitespace).

@maxonfjvipon
Copy link
Copy Markdown
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit 0a8d421 into objectionary:master Jan 23, 2026
27 checks passed
@0crat
Copy link
Copy Markdown

0crat commented Jan 27, 2026

@maxonfjvipon Thanks for the contribution! You've earned +12 points for this: +16 as a basis, -4 for contributing less than 40 hits-of-code (you had 36). According to our policy, contributions with fewer hits-of-code receive this deduction to encourage more substantial changes. Please keep them coming - aim for at least 40 hits-of-code next time to avoid the penalty! 🎯 Your running score is +208; don't forget to check your Zerocracy account too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FQN error in to-java.xsl

3 participants