refactor(#4862): remove unnecessary FpDefault references from tests#4865
Conversation
📝 WalkthroughWalkthroughThis PR removes most tests from FpDefaultTest.java, leaving a single cache-copy test ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
|
There was a problem hiding this comment.
Pull request overview
This PR is part of an ongoing effort to remove the FpDefault class from the codebase (issue #4862). Since FpDefault is only used in tests and is a composition of other Fp* classes that have their own tests, the project is gradually removing FpDefault tests in batches due to a 200-line limit per PR.
Changes:
- Removed 9 test methods from
FpDefaultTest.javathat test various scenarios ofFpDefaultbehavior - Kept 6 test methods that still use
FpDefaultfor removal in subsequent PRs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| @Test | ||
| void copiesFromCacheIfNoTaretAndExistedCacheableCacheOlder( |
There was a problem hiding this comment.
The test method name contains a typo: "Taret" should be "Target". This typo existed before this PR, but since the line is now adjacent to the diff (due to removed code above it), it should be corrected for consistency.
| void copiesFromCacheIfNoTaretAndExistedCacheableCacheOlder( | |
| void copiesFromCacheIfNoTargetAndExistedCacheableCacheOlder( |
751bbf0 to
99eeefd
Compare
|
@yegor256 could you have a look, please? |
|
@yegor256 friendly reminder |
|
@volodya-lombrozo Thanks for the contribution! You've earned +12 points for this: +16 as a basis, +9.45 for your 189 hits-of-code (189 × 0.05), but -4 deducted since you exceeded 100 hits-of-code, and -9.45 to cap the hit-of-code bonus at 16 points maximum. According to our policy, contributions over 100 hits-of-code get penalized to encourage smaller, more focused changes that are easier to review and maintain. Please keep them coming, but consider breaking larger contributions into smaller chunks! 🎯 Your running score is +402; don't forget to check your Zerocracy account too. |
This PR removes unnecessary references to
FpDefaultin theeo-maven-plugincode.I don't remove all of them because we have a limit in 200 lines. The next tests will be removed in following PRs.
Related to #4862
Summary by CodeRabbit