Conversation
75a2dd2 to
1a05337
Compare
Fil
reviewed
Jun 25, 2023
Fil
reviewed
Jun 25, 2023
| throw new Error("unable to format time ticks"); | ||
| } | ||
|
|
||
| function getTimeTicksInterval(scale, ticks) { |
Contributor
There was a problem hiding this comment.
This function being a bit difficult to grokk, I've made a chart to understand at which exact values the transitions happen; e.g., 707ms—the geometric mean of 500ms and 1000ms.
Member
Author
There was a problem hiding this comment.
It’s gotta match the behavior of d3.utcTicks.
Co-authored-by: Philippe Rivière <[email protected]>
52556e2 to
d689f98
Compare
Fil
approved these changes
Jun 25, 2023
nachocab
added a commit
to nachocab/plot
that referenced
this pull request
Jun 26, 2023
Probably not needed now that observablehq#1285 was closed by observablehq#1718
Fil
pushed a commit
that referenced
this pull request
Jun 26, 2023
Fil
added a commit
that referenced
this pull request
Jun 27, 2023
mbostock
added a commit
that referenced
this pull request
Jun 27, 2023
* document multi-line tick format (ref: #1718, #1725) * Update docs/marks/axis.md Co-authored-by: Mike Bostock <[email protected]> * better formats for explicit intervals --------- Co-authored-by: Mike Bostock <[email protected]>
Fil
added a commit
that referenced
this pull request
Aug 21, 2023
* remove maybeAutoTickFormat * multi-line time format * Update test/plots/covid-ihme-projected-deaths.ts Co-authored-by: Philippe Rivière <[email protected]> * link to d3-time * fix test size --------- Co-authored-by: Philippe Rivière <[email protected]>
Fil
pushed a commit
that referenced
this pull request
Aug 21, 2023
Fil
added a commit
that referenced
this pull request
Aug 21, 2023
* document multi-line tick format (ref: #1718, #1725) * Update docs/marks/axis.md Co-authored-by: Mike Bostock <[email protected]> * better formats for explicit intervals --------- Co-authored-by: Mike Bostock <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* remove maybeAutoTickFormat * multi-line time format * Update test/plots/covid-ihme-projected-deaths.ts Co-authored-by: Philippe Rivière <[email protected]> * link to d3-time * fix test size --------- Co-authored-by: Philippe Rivière <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Probably not needed now that observablehq#1285 was closed by observablehq#1718
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
…ervablehq#1728) * document multi-line tick format (ref: observablehq#1718, observablehq#1725) * Update docs/marks/axis.md Co-authored-by: Mike Bostock <[email protected]> * better formats for explicit intervals --------- Co-authored-by: Mike Bostock <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1285.
TODO
It would also be nice to have a better format for explicit tick time intervals #932, but I’ve left that for future work.