tip on a geo mark without a projection should not collapse the chart#1746
Merged
tip on a geo mark without a projection should not collapse the chart#1746
Conversation
Fil
added a commit
that referenced
this pull request
Aug 21, 2023
…1746) * fix collapsing bug (#1742) * avoid array.includes --------- Co-authored-by: Mike Bostock <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
…bservablehq#1746) * fix collapsing bug (observablehq#1742) * avoid array.includes --------- Co-authored-by: Mike Bostock <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1742
when adding tip: true on a geo mark, we create an initializer that generates new channels for the derived tip mark, typically geometry, and x and y if the geoCentroid transform or the centroid initializer were applied.
However:
Demo: https://observablehq.com/@fil/geo-tip-true-1746