better error message for missing stack value#1798
Merged
Conversation
Fil
approved these changes
Aug 9, 2023
8a717a6 to
e431364
Compare
Fil
pushed a commit
that referenced
this pull request
Aug 21, 2023
* better error message for missing channel * linked pointer example * shorten error message
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* better error message for missing channel * linked pointer example * shorten error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, I tried this:
This leads to a vague error:
The error can be reproduced as:
In the context of valueof, I think the error is okay: if you specify an array type then (I guess?) the value argument must not be null. But in the broader context of the stack transform, the stackY transform requires that y not be null since it will subsequently dereference those values even if we allowed valueof to return null here. So I think it’s better that we abort early with a more helpful error message.
Eventually I realized I could use rect instead of rectY, and by not specifying y, the rect spans the vertical extent of the chart and I don’t need rectY’s implicit stacking. I think this makes a nice test based on #1795.