Conversation
mbostock
reviewed
Apr 8, 2024
Member
mbostock
left a comment
There was a problem hiding this comment.
Seems correct but I’m curious how the svg.value gets set erroneously in the first place, and what prevents it from subsequently getting set again in the wrong place? (I can investigate this myself by looking at the code, but if you’re willing it would be nice to summarize more of what the underlying cause is here.)
Contributor
Author
|
The pointer transform initializes svg.value: plot/src/interactions/pointer.js Line 182 in 00610bb it dispatches here before we actually have a figure: plot/src/interactions/pointer.js Line 129 in 00610bb Once the figure has replaced the svg, the value is dispatched correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2045