limit numerical precision of test snapshots; fix node 22#2234
Closed
limit numerical precision of test snapshots; fix node 22#2234
Conversation
Member
Author
|
This is now blocked by Automattic/node-canvas#2448. I made some pretty good progress switching to skia-canvas instead, and using module-alias to point JSDOM at skia-canvas instead of canvas. But it looks like image rendering (raster mark) still isn’t working, so that hit a dead end. Then I looked at upgrading to canvas 3.0.0-rc2, which supports Node 22, but that also changes the API in a way that breaks JSDOM Automattic/node-canvas#2390. In fact they fixed it in Automattic/node-canvas#2409, but they haven’t released a new release candidate yet, so there’s not currently a way to install a version that’s compatible with both Node 22 and JSDOM. 😓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This limits numerical precision to three fractional digits, similar to what we already do via d3-shape and d3-path (ref. #1193 #1143). Reduces the test snapshots from 58M to 51M. It looks like one test (projectionClipAngle) is still broken, I would guess to some other numerical instability that will be harder to fix. So, I may just not worry about having the test snapshots work on both Node 20 and Node 22, and only test against 22.
Related, it would be nice if Plot limited the precision of numeric attributes and numbers interpolated into templates by default, since we already do this for path data.