win-dshow: Fix CreateFileW return value check in virtualcam filter#13134
Open
xtfo wants to merge 1 commit intoobsproject:masterfrom
Open
win-dshow: Fix CreateFileW return value check in virtualcam filter#13134xtfo wants to merge 1 commit intoobsproject:masterfrom
xtfo wants to merge 1 commit intoobsproject:masterfrom
Conversation
CreateFileW returns INVALID_HANDLE_VALUE on failure, not NULL. The previous check would always evaluate to true on failure, causing ReadFile and CloseHandle to be called on an invalid handle.
notr1ch
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CreateFileW returns INVALID_HANDLE_VALUE on failure, not NULL. The previous check would always evaluate to true on failure, causing ReadFile and CloseHandle to be called on an invalid handle.
Motivation and Context
Fixes bug.
How Has This Been Tested?
Tested the virtual camera.
Types of changes
Checklist: