This repository was archived by the owner on Jun 21, 2024. It is now read-only.
Add std gnu11 common cflags #610
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct the correct standard
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #574 with @kate and @Sudha247 we noticed that it seems there's a discrepancy in what kind of flags OCaml packages are using to build C stubs against the runtime.
This does not address further issues in the ecosystem (I'll update #574 with the problematic packages.), but at least it allows people using
ocamlc -configto retrieve the correct C flags to select the right C variant.For now I added it to Clang and GCC, and I'm not quite sure this is entirely required, however I feel like that being explicit on it is better than not.