Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ci): add zizmor pedantic persona and suppress noisy findings#50

Merged
stevebeattie merged 1 commit into
octo-sts:mainfrom
stevebeattie:security/psec-923-action
May 5, 2026
Merged

fix(ci): add zizmor pedantic persona and suppress noisy findings#50
stevebeattie merged 1 commit into
octo-sts:mainfrom
stevebeattie:security/psec-923-action

Conversation

@stevebeattie

Copy link
Copy Markdown
Contributor

fix(ci): add zizmor pedantic persona and suppress noisy findings

Summary

This repo was largely clean: all action refs were already SHA-pinned and harden-runner
was already present in all jobs. The only automated fix is updating .github/zizmor.yml
to suppress low-value noisy rules and enable the pedantic persona in CI.

Changes

  • Patch 1: Update .github/zizmor.yml to suppress concurrency-limits,
    anonymous-definition, and undocumented-permissions; switch CI zizmor to
    --pedantic persona

Manual review items

  • CRITICAL: dangerous-triggerspull_request_target trigger in
    use-action.yaml runs the action from the PR fork with id-token: write. See
    manual-review.md for full analysis and remediation options.

Testing

  • zizmor finding count before: 4 (3x concurrency-limits, 1x dangerous-triggers)
  • After applying patch: 1 remaining (dangerous-triggers — intentional, requires
    architectural fix documented in manual-review.md)
  • actionlint: 0 findings
  • All action refs already SHA-pinned

References

  • Linear: PSEC-923
  • Branch: security/psec-923-action

- Enable pedantic persona in zizmor CI via zizmor-action `persona` input
- Suppress concurrency-limits, anonymous-definition, and
  undocumented-permissions in .github/zizmor.yml; these are low-value
  findings that do not represent exploitable security issues in this repo

Refs: PSEC-923
@stevebeattie stevebeattie enabled auto-merge (squash) May 5, 2026 04:38
@stevebeattie stevebeattie requested a review from egibs May 5, 2026 19:41
@stevebeattie stevebeattie merged commit baf4991 into octo-sts:main May 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants