Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Sep 24, 2024

Relates to octokit/tsconfig#29 (comment)


Before the change?

  • We were testing types without --exactOptionalPropertyTypes option

After the change?

  • We start testing types with --exactOptionalPropertyTypes option

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@oscard0m oscard0m requested a review from wolfy1339 September 24, 2024 22:17
@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 24, 2024
@oscard0m oscard0m force-pushed the add-exactOptionalPropertyTypes-option-to-test-ts branch from 698fd39 to 92b66c2 Compare September 24, 2024 22:17
@wolfy1339
Copy link
Member

Could be combined with #646

@oscard0m oscard0m force-pushed the add-exactOptionalPropertyTypes-option-to-test-ts branch from 92b66c2 to f260633 Compare September 24, 2024 22:22
@oscard0m oscard0m closed this Sep 24, 2024
@wolfy1339 wolfy1339 deleted the add-exactOptionalPropertyTypes-option-to-test-ts branch September 24, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants