Initial version #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix conditionals to stop test from crashing
fix session initialization from response
gr2m
reviewed
Sep 30, 2021
| @@ -55,7 +55,7 @@ export async function auth< | |||
| } as GetWebFlowAuthorizationUrlOptions<Client>; | |||
|
|
|||
| if (options.clientType === "oauth-app") { | |||
| options.scopes = command.scopes ?? this.defaultScopes; | |||
| options.scopes = command.scopes ? this.defaultScopes : command.scopes; | |||
There was a problem hiding this comment.
shouldn't this be the other way around? I think we could also do
Suggested change
| options.scopes = command.scopes ? this.defaultScopes : command.scopes; | |
| options.scopes = command.scopes || this.defaultScopes |
5439c1b to
69fe788
Compare
|
I'm confused about the linting error, I cannot reproduce it locally 🤷🏼 I do however see the |
|
This PR could be closed because of #8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gr2m Sorry, left a comment from the wrong account. this PR should fix tests and remove the bug