build(tsconfig): use @octokit/tsconfig preset in local tsconfig.json #290
Conversation
| "target": "es2020", | ||
| "resolveJsonModule": true | ||
| }, | ||
| "extends": "@octokit/tsconfig", | ||
| "include": ["src/**/*"] |
There was a problem hiding this comment.
We still need to use include here because include from the extends is resolved from the relative path where is extended from:
https://www.typescriptlang.org/tsconfig#extends
Do you know a way to make it work at "preset" level? If not, I guess we will need to remove that entry in @octokit/tsconfig right?
There was a problem hiding this comment.
Yes, it seems like it. There is an open discussion about it here: microsoft/TypeScript#25430
Let's remove the "include" key from @octokit/tsconfig. Do you want to send a PR?
There was a problem hiding this comment.
Yes, it seems like it. There is an open discussion about it here: microsoft/TypeScript#25430
Let's remove the
"include"key from@octokit/tsconfig. Do you want to send a PR?
Done
|
🎉 This PR is included in version 7.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
📝 Summary
Replace local
tsconfig.jsonconfiguration by the one inherited from@octokit/tsconfig⛱ Motivation and Context
Adopt
@octokit/tsconfigin all repos using TSFix #289