-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[IMP] studio: updating automation rules and webhooks #13059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee6588c
to
681647b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mcsi-odoo, thank you so much for your fantastic work on this! 🙌
I've added a few comments and suggestions, particularly in the Webhooks file where I suggested refining some of the existing content a bit further.
I’ve also included a few questions/discussion points (some are just out of curiosity, and others because I wasn’t fully confident in a solution and would really like your opinion and brain power!)
Thanks again for taking care of this so quickly!
681647b
to
ba0894e
Compare
ba0894e
to
27d5b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates @mcsi-odoo! And thank you for your patience while I try to catch up! I only have a few comments, mostly minor ones 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most comments resolved after suggested change implemented.
I replied on some, and will share a new version shortly - main update to note is clarification on the 240 mins vs 2400 mins.
27d5b93
to
e38abe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @mcsi-odoo ! Thank you for the changes and clarification 🙂
@robodoo r+
Task-4672373