[ADD] timesheets: billing rate leaderboad #13921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8d75a8d to
b01afc2
Compare
4734f22 to
3e84da4
Compare
auva-odoo
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Thank you for your work @zulu-odoo! I added a few comments and suggestions 🙂. Also:
- Could you please change the PR title and commit message to change [NEW] into [ADD]?
- Don't forget the app name in your anchor names (timesheets/billing_rates/xxx)
- Could we use this opportunity (i.e., PR) to get rid of the empty "Overview" toc tree?
Thank you!
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
Comment on lines
23
to
24
| A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | ||
| set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly |
There was a problem hiding this comment.
- We don't usually mention that menu items are "added" and instead focus on actionable steps (e.g., To configure xxx, go to yy --> zz --> aa, enable blabla, etc.)
- This is only true from 18.2; in 18.0, you need to click the internal link under the setting
Suggested change
| A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | |
| set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly | |
| To set up the targets, click :guilabel:`Set employee billing time targets`, then encode the :guilabel:`Monthly |
in 18.2, I'd add the menu as an alternative:
Suggested change
| A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | |
| set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly | |
| To set up the targets, click :guilabel:`Set employee billing time targets` or go to :menuselection:`Timesheets --> Configuration --> Billing Time Targets`, then encode the :guilabel:`Monthly |
There was a problem hiding this comment.
Noted for 18.2! Thank you for catching it <3
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
| --------------------------------- | ||
|
|
||
| Once enabled, the billing rate indicators are displayed in the upper right corner of the | ||
| :guilabel:`My Timesheets` in Kanban, grid, and list views for all users. The monthly amount of time |
There was a problem hiding this comment.
I feel like a word is missing after "My timesheets" but I'm not sure what would work here. Any ideas?
There was a problem hiding this comment.
A word WAS missing, I don't know how I did that! I actually also had a hard time coming up with what to call it, I remember asking Dallas (you weren't there, TRAGICALLY), and we went with "menu". But we can definitely discuss together if it doesn't work for you!
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
| It also shows the amount of the time logged by the signed in user in the format: logged billable | ||
| time / billable time target, as well as the total time logged. |
There was a problem hiding this comment.
Suggested change
| It also shows the amount of the time logged by the signed in user in the format: logged billable | |
| time / billable time target, as well as the total time logged. | |
| It also shows the amount of time logged by the signed-in user in the format: logged billable | |
| time / billable time target, as well as the total time logged. |
There was a problem hiding this comment.
THE AMOUNT OF THE TIME hahahaha I love it, I wish we could keep it! (but it's fixed now, rip)
Comment on lines
90
to
91
| To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`. | ||
| To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text. |
There was a problem hiding this comment.
I feel like maybe we could group these two sentences (it would also avoid repetitions):
Suggested change
| To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`. | |
| To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text. | |
| To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`, then click :guilabel:`New` or double-click a tip's text. |
39a8f9f to
7a89034
Compare
7a89034 to
0d055dc
Compare
|
Hi @auva-odoo , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-id: 4882126