-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[ADD] Project: New page about visibility and collaboration #14040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work @guga-odoo ! Since this feature is relatively minor and, as I understand it, part of the standard project settings, I’d suggest adding it to the Project Management page (as a sub-section of Configuraiton) rather than creating a new one. My review comments reflect that approach (e.g. we won't need to repeat how to access the project settings) but let's discuss this if you see it differently!
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
- :guilabel:`Invited internal users (private)`: When following a project, internal users will have | ||
access to all of its tasks without distinction. Otherwise, they will only have access to the | ||
specific tasks they are following. A user with the Project app administrator access rights level | ||
can still access the project and its tasks, even if they are not listed as followers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's try to avoid using the future tense where possible.
- I'm not sure I understand; by "otherwise", did you mean "if this option is selected"? The following suggestion assumes you did; feel free to change it (and clarify) if you didn't 😉.
- :guilabel:`Invited internal users (private)`: When following a project, internal users will have | |
access to all of its tasks without distinction. Otherwise, they will only have access to the | |
specific tasks they are following. A user with the Project app administrator access rights level | |
can still access the project and its tasks, even if they are not listed as followers. | |
- :guilabel:`Invited internal users (private)`: Only users following the project and users with the Project Administrator :doc:`access right <add link to this doc: https://www.odoo.com/documentation/master/applications/general/users/access_rights.htm>` can access the project and its tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got it right!
Also, sorry about the future tense. I thought the tool tips in the apps were well phrased and saw an opportunity to streamline the doc with the app tool tips, but then I forgot about the tense. Thanks for the reminder!
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
content/applications/services/project/project_management/visibility_collaboration.rst
Show resolved
Hide resolved
- :guilabel:`Edit`: Collaborators can view and edit all tasks in the Kanban view and choose which | ||
tasks they want to follow. | ||
|
||
To revoke an invited collaborator's access, click the :icon:`fa-trash-o` :guilabel:`(fa-trash-o)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To revoke an invited collaborator's access, click the :icon:`fa-trash-o` :guilabel:`(fa-trash-o)` | |
To revoke an invited collaborator's access, click the :icon:`fa-trash-o` :guilabel:`(delete)` |
or you could use "trash" but I would definitely remove the "technical" part of the icon's name 😉
And should we repeat the "Click the Share project button" part, just in case? (i was actually expecting to find the user's name under the Visibility field and had to check (but it might just be me!)
In any case, an internal user with no project access rights can still access a task, provided | ||
that they are given the corresponding URL (and that they are part of the followers if the project | ||
is private). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, an internal user with no project access rights can still access a task, provided | |
that they are given the corresponding URL (and that they are part of the followers if the project | |
is private). | |
Internal users without access to the project can still access a task if the URL has been shared with them. For private projects, they must also be a follower of the task. |
- I'm not sure what you meant by "project access rights" but I would not use the word "access right" unless it is an actual access right (as in: https://www.odoo.com/documentation/master/applications/general/users/access_rights.html) ; feel free to change this suggestion if it is not what you meant.
- I would also clarify what you mean "by private project", I'm not really sure?
task-4946930