-
Notifications
You must be signed in to change notification settings - Fork 29.6k
19.0 valo quick fix arm #227073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fw-bot
wants to merge
6
commits into
odoo:master
from
odoo-dev:master-19.0-valo-quick-fix-arm-462855-fw
Closed
19.0 valo quick fix arm #227073
fw-bot
wants to merge
6
commits into
odoo:master
from
odoo-dev:master-19.0-valo-quick-fix-arm-462855-fw
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the inventory value is based on the product global FIFO stack. It's completely wrong for lot valuation since they have all their own stack. In order to get the product total value we look at all the value of their lot instead X-original-commit: 9ea2f55
`_get_stock_valuation_account_vals` function needs the entries generated for location with valuation account. It's used to correctly know the already removed or added value in stock_valuation account. However in the report it correctly does it for inventory loss but it forgets the cost of production. The fix just call the function to generate all the location entries without domain. X-original-commit: 6897b9d
Allow to update the effective date of a done move. It will have an impact on valuation since it could completely break the FIFO stack even for move that are already out. Thus it could invalidate the COGS entries since they don't respect the new order. However the closing always check the last valuation state and will correct the inconsistent state. But the out `stock.move` will never be recomputed. So it's a bad idea to use computation on move `value` if you want to use breaking update like this. Also fix the issue with the valuation report at date. It pass the required date as parameter and add it in every domain to reflect the past state X-original-commit: e5453bc
Before the on_hand quantity filter was added to only show the quant under a warehouse. Now there is only a filter on internal location that display everything but the qty_available still filter on warehouse's locations. This commit add a warehouse_id set on location to have the same behavior than before X-original-commit: 034f13e
When the product is in realtime accounting and the production location has a variation account. The labor expense will be created and posted directly as in 18.0 X-original-commit: 7091949
On stock valuation account rename the expense account as expense. It will be easier for customer to understand. X-original-commit: 3ef982a
@amoyaux this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
Currently the inventory value is based on the product global FIFO stack. It's completely wrong for lot valuation since they have all their own stack. In order to get the product total value we look at all the value of their lot instead X-original-commit: 9ea2f55 Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
`_get_stock_valuation_account_vals` function needs the entries generated for location with valuation account. It's used to correctly know the already removed or added value in stock_valuation account. However in the report it correctly does it for inventory loss but it forgets the cost of production. The fix just call the function to generate all the location entries without domain. X-original-commit: 6897b9d Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
Allow to update the effective date of a done move. It will have an impact on valuation since it could completely break the FIFO stack even for move that are already out. Thus it could invalidate the COGS entries since they don't respect the new order. However the closing always check the last valuation state and will correct the inconsistent state. But the out `stock.move` will never be recomputed. So it's a bad idea to use computation on move `value` if you want to use breaking update like this. Also fix the issue with the valuation report at date. It pass the required date as parameter and add it in every domain to reflect the past state X-original-commit: e5453bc Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
Before the on_hand quantity filter was added to only show the quant under a warehouse. Now there is only a filter on internal location that display everything but the qty_available still filter on warehouse's locations. This commit add a warehouse_id set on location to have the same behavior than before X-original-commit: 034f13e Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
When the product is in realtime accounting and the production location has a variation account. The labor expense will be created and posted directly as in 18.0 X-original-commit: 7091949 Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
On stock valuation account rename the expense account as expense. It will be easier for customer to understand. closes #227073 X-original-commit: 3ef982a Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
Currently the inventory value is based on the product global FIFO stack. It's completely wrong for lot valuation since they have all their own stack. In order to get the product total value we look at all the value of their lot instead X-original-commit: 9ea2f55 Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
`_get_stock_valuation_account_vals` function needs the entries generated for location with valuation account. It's used to correctly know the already removed or added value in stock_valuation account. However in the report it correctly does it for inventory loss but it forgets the cost of production. The fix just call the function to generate all the location entries without domain. X-original-commit: 6897b9d Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
Allow to update the effective date of a done move. It will have an impact on valuation since it could completely break the FIFO stack even for move that are already out. Thus it could invalidate the COGS entries since they don't respect the new order. However the closing always check the last valuation state and will correct the inconsistent state. But the out `stock.move` will never be recomputed. So it's a bad idea to use computation on move `value` if you want to use breaking update like this. Also fix the issue with the valuation report at date. It pass the required date as parameter and add it in every domain to reflect the past state X-original-commit: e5453bc Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
Before the on_hand quantity filter was added to only show the quant under a warehouse. Now there is only a filter on internal location that display everything but the qty_available still filter on warehouse's locations. This commit add a warehouse_id set on location to have the same behavior than before X-original-commit: 034f13e Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
When the product is in realtime accounting and the production location has a variation account. The labor expense will be created and posted directly as in 18.0 X-original-commit: 7091949 Part-of: #227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 16, 2025
On stock valuation account rename the expense account as expense. It will be easier for customer to understand. closes #227073 X-original-commit: 3ef982a Signed-off-by: Arnold Moyaux (arm) <[email protected]>
phenix-factory
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 16, 2025
Currently the inventory value is based on the product global FIFO stack. It's completely wrong for lot valuation since they have all their own stack. In order to get the product total value we look at all the value of their lot instead X-original-commit: 9ea2f55 Part-of: odoo#227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
phenix-factory
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 16, 2025
`_get_stock_valuation_account_vals` function needs the entries generated for location with valuation account. It's used to correctly know the already removed or added value in stock_valuation account. However in the report it correctly does it for inventory loss but it forgets the cost of production. The fix just call the function to generate all the location entries without domain. X-original-commit: 6897b9d Part-of: odoo#227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
phenix-factory
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 16, 2025
Allow to update the effective date of a done move. It will have an impact on valuation since it could completely break the FIFO stack even for move that are already out. Thus it could invalidate the COGS entries since they don't respect the new order. However the closing always check the last valuation state and will correct the inconsistent state. But the out `stock.move` will never be recomputed. So it's a bad idea to use computation on move `value` if you want to use breaking update like this. Also fix the issue with the valuation report at date. It pass the required date as parameter and add it in every domain to reflect the past state X-original-commit: e5453bc Part-of: odoo#227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
phenix-factory
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 16, 2025
Before the on_hand quantity filter was added to only show the quant under a warehouse. Now there is only a filter on internal location that display everything but the qty_available still filter on warehouse's locations. This commit add a warehouse_id set on location to have the same behavior than before X-original-commit: 034f13e Part-of: odoo#227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
phenix-factory
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 16, 2025
When the product is in realtime accounting and the production location has a variation account. The labor expense will be created and posted directly as in 18.0 X-original-commit: 7091949 Part-of: odoo#227073 Signed-off-by: Arnold Moyaux (arm) <[email protected]>
phenix-factory
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 16, 2025
On stock valuation account rename the expense account as expense. It will be easier for customer to understand. closes odoo#227073 X-original-commit: 3ef982a Signed-off-by: Arnold Moyaux (arm) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #226899