git cmd on windows now runs without the shell, see diff for explanation

Byron · Byron · commit a67bf61b5017 · 2009-11-05T18:27:21.000+01:00
diff --git a/lib/git/cmd.py b/lib/git/cmd.py
@@ -17,8 +17,13 @@
 				  'output_stream' )
 
 extra = {}
-if sys.platform == 'win32':
-	extra = {'shell': True}
+# NOTE: Execution through a shell appears to be slightly faster, but in fact
+# I consider it a problem whenever complex strings are passed and *interpreted* 
+# by the shell beforehand. This can cause great confusion and reduces compatability
+# between the OS which is why the shell should not be used ( unless it does not work
+# otherwise )
+#if sys.platform == 'win32':
+#	extra = {'shell': False}
 
 def dashify(string):
 	return string.replace('_', '-')
