runner/handler_test.go (1)

665-700: 🧹 Nitpick | 🔵 Trivial

LGTM! テストが新しい動作を正しく検証しています。

ip:port形式のフルアドレスがauditログに記録されることを確認するテストに更新されており、handler.goの変更と整合しています。

AI生成サマリーによるとTestExecuteCloudFrontViewerAddressWithoutPortが削除されていますが、CloudFrontは常にポートを含むため、この削除は妥当です。

IPv6アドレスのテストケースを追加すると、カバレッジがより包括的になります：

📝 IPv6テストケースの追加案

// TestExecuteCloudFrontViewerAddressIPv6 verifies that IPv6 addresses with port
// are preserved in the audit log remote field.
func TestExecuteCloudFrontViewerAddressIPv6(t *testing.T) {
	var buf bytes.Buffer
	log.SetOutput(&buf)
	defer log.SetOutput(os.Stderr)

	sm := NewSessionManager()
	defer sm.CloseAll()
	sm.newShell = func() (Shell, error) {
		return &mockShell{exitCode: 0}, nil
	}
	handler := newHandler(sm, nil)

	id, _, err := sm.Create()
	if err != nil {
		t.Fatalf("Create() error: %v", err)
	}

	body := strings.NewReader(`{"command":"ls"}`)
	req := httptest.NewRequest(http.MethodPost, "/api/execute", body)
	req.AddCookie(&http.Cookie{Name: "session_id", Value: id})
	req.Header.Set("CloudFront-Viewer-Address", "[2001:db8::1]:54321")
	w := httptest.NewRecorder()
	handler.ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("status = %d, want %d", w.Code, http.StatusOK)
	}

	logOutput := buf.String()
	if !strings.Contains(logOutput, "remote=[2001:db8::1]:54321") {
		t.Fatalf("expected audit log to contain remote=[2001:db8::1]:54321, got:\n%s", logOutput)
	}
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@runner/handler_test.go` around lines 665 - 700, Add an IPv6 test analogous to
TestExecuteCloudFrontViewerAddress to ensure bracketed IPv6+port values are
preserved in the audit remote field: create
TestExecuteCloudFrontViewerAddressIPv6 that sets up a SessionManager (sm), uses
sm.newShell to return a mockShell, creates a handler via newHandler(sm, nil),
issues an httptest POST to /api/execute with the session_id cookie and header
CloudFront-Viewer-Address set to "[2001:db8::1]:54321", calls handler.ServeHTTP,
asserts status OK, captures log output, and verifies it contains
"remote=[2001:db8::1]:54321" (matching the pattern used in the existing
TestExecuteCloudFrontViewerAddress).