You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in ogdf. It must add include <chrono> to fix this error.
Compiler error with this STL change:
D:\b\ogdf\src\3b65b433a9-facc12a078.clean\src\ogdf\cluster\HananiTutteCPlanarity.cpp(47): error C2039: 'high_resolution_clock': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.41.34120\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\b\ogdf\src\3b65b433a9-facc12a078.clean\src\ogdf\cluster\HananiTutteCPlanarity.cpp(47): error C2873: 'high_resolution_clock': symbol cannot be used in a using-declaration
Ah, thanks! I've already seen this issue come up in a CI run here, although for newer files that haven't made it into a release yet. I'll see what CI now says with this one change, fix any further files that need fixing and then merge. Is that enough for vcpkg or do you need a backport?
Ah, thanks! I've already seen this issue come up in a CI run here, although for newer files that haven't made it into a release yet. I'll see what CI now says with this one change, fix any further files that need fixing and then merge. Is that enough for vcpkg or do you need a backport?
Thanks for your reply, I have already fixed this issue in vcpkg by adding a patch. The related PR link is: microsoft/vcpkg#42399. Once this PR is merged, we will remove the related patch the next time we update ogdf in vcpkg.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in
ogdf. It must add include<chrono>to fix this error.Compiler error with this STL change: