envconfig: fall back to default on invalid bool env values#14563
Open
umut-polat wants to merge 1 commit intoollama:mainfrom
Open
envconfig: fall back to default on invalid bool env values#14563umut-polat wants to merge 1 commit intoollama:mainfrom
umut-polat wants to merge 1 commit intoollama:mainfrom
Conversation
BoolWithDefault returned true when strconv.ParseBool failed instead of returning the provided default value. This caused boolean flags to be silently enabled when a user set an env var to a common but invalid string like "yes", "on", or "enabled". Fixes ollama#14389 Signed-off-by: umut-polat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoolWithDefault returned true when strconv.ParseBool failed instead of returning the provided default value. This caused boolean flags to be silently enabled when a user set an env var to a common but invalid string like "yes", "on", or "enabled".
The fix changes the error fallback from
return truetoreturn defaultValue.Fixes #14389